Improve performance of add/sub when exponent of two bigdecimals have huge difference #478
+71
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…huge difference
BigDecimal('1e+10000000000').add(1, 10) allocates GB of memory.
BigDecimal('1e+10000000000').add(BigDecimal('0.1e+9999999990'), 10) will give the same rounding result with less memory allocation and computation time.
tompng
force-pushed
the
addsub_huge_exponent_diff
branch
from
97be589 to
0649946
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #464
BigDecimal('1e+10000000000').add(1, 10)allocates GB of memory.BigDecimal('1e+10000000000').add(BigDecimal('0.1e+9999999990'), 10)will give the same rounding result with less memory allocation and computation time.Also fixes this NoMemoryError